search

GovAlta / ui-components

ui-components contains the code you need to start building a user interface for Government of Alberta platforms and services.
Apache License 2.0
15 stars 24 forks source link

Date Picker: Margins not working #1501

Open ArakTaiRoth opened 9 months ago

ArakTaiRoth commented 9 months ago

Info

If you use any of the margin properties (mr, mt, mb, or ml) with the Datepicker component, nothing happens. Tested in React, not tested in Angular.

Acceptance Criteria:

  1. The margin properties should add spacing around the Datepicker component
bdfranck commented 4 months ago

Has this issue already been resolved in the alpha branch? 🤔 I couldn't replicate it in my playground.

When I added the following to my Web playground... <goa-date-picker name="item" error="false" mt="m" mb="m" ml="m" mr="m" value={datePickerDate}></goa-date-picker>

I can see the margins around the input: Image

And when I added the following to my React playground... <GoADatePicker onChange={onChange} mt="m" mb="m" ml="m" mr="m" berror={false} value={new Date()}></GoADatePicker>

I can also see the margins around the input: Image

Or is there a specific context where this issue arises?

chrisolsen commented 2 months ago

I am also unable to replicate this issue.