GovAlta / ui-components

ui-components contains the code you need to start building a user interface for Government of Alberta platforms and services.
Apache License 2.0
15 stars 24 forks source link

Radio: Can't dynamically change error property #1972

Closed ArakTaiRoth closed 2 months ago

ArakTaiRoth commented 3 months ago

Info

Using this code:

<goa-radio-group name="item" [error]="errorVariable" mb="xl">
  <goa-radio-item
    value="Test 1"
    label="Test 1"
  />
  <goa-radio-item
    value="Test 2"
    label="Test 2"
  />
  <goa-radio-item
    value="Test 3"
    label="Test 3"
  />
</goa-radio-group>
<br />
<goa-button (_click)="onClick()">Set Error</goa-button>
export class RadioComponent {
  errorVariable = false;

  onClick() {
    this.errorVariable = false;
  }
}

You can replicate the issue. The page loads with no error set on the Radio Group. If you click the button, the expected behaviour is that the error property is set to true on the Radio Group. The actual behaviour is that nothing happens. If you go back to web-components version 1.19.1, this exact same code works as expected. This is the only PR I can see in the 1.20.0 upgrade that affected the Radio Group specifically.

Acceptance Criteria:

  1. You can change the error property dynamically on the Radio Group component
  2. Ken to setup Cypress test for this scenario
  3. Test helper text property as well
Spark450 commented 3 months ago

@ArakTaiRoth can we narrow this down to which commit broke this feature?

tzuge commented 2 months ago

:tada: This issue has been resolved in version 1.17.0-alpha.80 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tzuge commented 2 months ago

:tada: This issue has been resolved in version 4.17.0-alpha.33 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tzuge commented 2 months ago

:tada: This issue has been resolved in version 1.23.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tzuge commented 2 months ago

:tada: This issue has been resolved in version 4.22.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tzuge commented 2 weeks ago

:tada: This issue has been resolved in version 3.0.0-alpha.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: