search

GovReady / govready-q

An open source, self-service GRC tool to automate security assessments and compliance.
https://q.govready.com
Other
180 stars 58 forks source link

Speed up performance of control select #1669

Closed gregelin closed 3 years ago

gregelin commented 3 years ago

Describe the issue as a Story Selecting drop down list of controls for adding a component control statement is very slow. Needs to be speed up

To Reproduce Steps to reproduce the behavior:

  1. Visit: http://localhost:9000/controls/components/94 (or any component in component library)
  2. Click on add component information button
  3. Enter a control ID
  4. See performance is slow

Code

original:

url(r'^api/controlsselect/', views.api_controls_select, name="api_controls_select"),

possible revision

url(r'^api/controlsselect/control/(?P<cl_id>.*)', views.api_controls_select, name="api_controls_select"),

controls/views.py 

def api_controls_select

Instead of getting entire controls from all catalogs, get just the related controls by searching all catalogs.

gregelin commented 3 years ago

Being addressed in #1672

gregelin commented 3 years ago

Closed with merger of #1672 and #1681 and #1687.