Closed clye-cog closed 2 months ago
@clye-cog To keep date change event from mouse click and keyboard input consistent. It will be as follows
mode = "single" Mouse click --> onChangeDate called only after date is selected by mouse click Keyboard input --> onChangeDate called only after a valid date is typed into the input
mode="range" Mouse click --> onChangeDate called only after both start and end date is selected by mouse click Keyboard input --> onChangeDate called only after both valid start and end dates are typed into the input
Hi @clukhei , thank you for the reply. Yes I understand. However, even with a valid date, I am not able to trigger the change.
I can trigger a change using the mouse click. But I cannot trigger a change in date when a valid date is typed into the input.
Is there something I'm missing from this? I have attached a video I used in my app.
https://github.com/user-attachments/assets/96681dca-f796-46a6-b1e0-4605410b37a2
@clye-cog yes, its a bug that we missed out when we implemented the date input. Fix is on the way. Please wait for updates in this thread. will keep you posted when the changes are released.
No problem, thanks a lot @clukhei 🙏
@clye-cog The fix has been released in v2.6.1. Please upgrade @govtechsg/sgds-react
to version 2.6.1
https://github.com/GovTechSG/sgds-govtech-react/releases/tag/v2.6.1
Thanks @clukhei ! Tested and it works :)
Prerequisites
Describe the issue
https://github.com/user-attachments/assets/0c9a3e80-d22a-405b-9164-b7194f613792
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome
Describe your frontend stack. What version of React and @govtechsg/sgds-react are you using? CSR or SSR?
React v16. @govtechsg/sgds-react v2.5.1. CSR.