fix some issues with updated client

GovtGeek / Outfitter

Outfitter - Classic

MIT License

7 stars 2 forks source link

fix some issues with updated client #35

Closed freite closed 2 weeks ago

GovtGeek commented 1 month ago

Thanks for the pull request. I'm sorry, but I won't accept a PR against master. I do have a patch in progress that I'm working on. I see multiple changes in the PR as well, but I don't have a corresponding error that each is fixing that I can test against. If you can describe the issues and how to reproduce the errors and do PRs against a patch branch, that would help. I am going to cite you for the MouseOver fix, especially since it seems to have saved me a lot of time.

freite commented 1 month ago

fixes from the offical LibDropdown-1.0.lua, Outfitter for some reason uses a slightly modified version of that lib.
"OptionsCheckButtonTemplate" does no longer exist in the latest era/sod client but "OptionsBaseCheckButtonTemplate" still works. looks it's also under the "Deprecated" parts of blizzard ui though so making your own template might be a more future proof plan