search

Gowee / zhconv-rs

🦀 Convert Chinese text among Trad/Simp and regional variants | 中文简繁及地區詞轉換
https://zhconv.pages.dev
GNU General Public License v3.0
25 stars 3 forks source link

姓氏.json may not have region-specific translations #3

Closed BSBMteam closed 2 years ago

BSBMteam commented 2 years ago

This file has no region-specific translations. For example, some entries are perfect! Other entries just have one unspecified translation

Is this on purpose since 「于震」 can't be translated to 「於震」？

 {
      "original": null,
      "conv": "于娜"
    },
    {
      "original": null,
      "conv": "zh-hans:于荣光;zh-hant:于榮光"
    },
    {
      "original": null,
      "conv": "于震"
    },
    {
      "original": null,
      "conv": "zh-hans:于朦胧;zh-hant:于朦朧"
    },
Gowee commented 2 years ago

Yes. That is intended, I suppose.

Gowee commented 2 years ago

It turns out that I looked past such a kind of rule. The converter implementation doesn't process them properly. Fixing...

Thanks for reporting.