search

Gowerlabs / LibFTD2XX.jl

Julia wrapper for FTDI D2XX drivers.
Other
6 stars 1 forks source link

Compatibility for 0.7/1.0 #10

Closed samuelpowell closed 6 years ago

samuelpowell commented 6 years ago

Uses Compat to retain backwards compatibility with 0.6.

samuelpowell commented 6 years ago

I don't think you're on the right branch on 0.7 (perhaps not even on 0.6) because I fixed those

ReubenHill commented 6 years ago

Strange, I did (v0.7) pkg> add https://github.com/Gowerlabs/LibFTD2XX.jl#sp/07

samuelpowell commented 6 years ago

Well I don't know how broaches work when you add them, which is really for using them. I would suggest you develop... (v0.7) pkg> dev https://github.com/Gowerlabs/LibFTD2XX.jl#sp/07

This actually gets the git and puts it in .julia/dev for development work

ReubenHill commented 6 years ago

NB, that doesn't work

(v0.7) pkg> dev https://github.com/Gowerlabs/LibFTD2XX.jl#sp/07
ERROR: a git revision cannot be given to `develop`

Anyway, I manually switched branches and all looks good. The example code throws conversion warnings

julia> write(handle, Vector{UInt8}("Hello"))

warns 

Warning: Vector{UInt8}(s::String) will copy data in the future. To avoid copying, use `unsafe_wrap` or `codeunits` instead.

so the README.md might need updating but otherwise all looks good.

samuelpowell commented 6 years ago

Yeah that's not a package problem per se but feel free to push a change to the README

samuelpowell commented 6 years ago

I do it