Closed ReubenHill closed 5 years ago
Merging #27 into master will increase coverage by
57.36%
. The diff coverage is49.07%
.
@@ Coverage Diff @@
## master #27 +/- ##
===========================================
+ Coverage 2.8% 60.17% +57.36%
===========================================
Files 1 3 +2
Lines 107 231 +124
===========================================
+ Hits 3 139 +136
+ Misses 104 92 -12
Impacted Files | Coverage Δ | |
---|---|---|
src/wrapper.jl | 73.33% <100%> (ø) |
|
src/LibFTD2XX.jl | 43.8% <44.89%> (+41%) |
:arrow_up: |
src/util.jl | 83.33% <83.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dfe0102...6dea8de. Read the comment docs.
Drop 0.6 for sure
Ready for review. @samuelpowell do you know how to get codecoverage to update?
@ReubenHill it may be that the configuration scripts are out of date. I would suggest using PkgTemplates.jl
to create the files you want with the appropriate options and then graft them into this repo as appropriate.
@ReubenHill will clone and look through in further detail once you've addressed above
Also, I know it's a bit late now, but had you not considered using Clang.jl
? See e.g. Spinnaker.jl
to see what it does.
Also, I know it's a bit late now, but had you not considered using Clang.jl? See e.g. Spinnaker.jlto see what it does.
I decided learning how to use Clang.jl would take more time than expanding what I had already to cover more functions. In hindsight, that might have been wrong. The majority of this has been adding tests, making more robust and and adding high level stuff.
Big pull request which changes the API and makes everything much more robust.
Notes
LibFTD2XX.Wrapper
(resolves #8)Issues
FTOpenEx
withFT_OPEN_BY_LOCATION
flag..Wrapper
functions which fail throwFT_STATUS_ENUM
s instead of exceptions. This should be replaced with a suitable exception type.Todo
FTOpenEx
withFT_OPEN_BY_LOCATION
flag.