Gowerlabs / LibFTD2XX.jl

Julia wrapper for FTDI D2XX drivers.
Other
6 stars 1 forks source link

Refactor and Add Tests #27

Closed ReubenHill closed 5 years ago

ReubenHill commented 5 years ago

Big pull request which changes the API and makes everything much more robust.

Notes

Issues

Todo

codecov-io commented 5 years ago

Codecov Report

Merging #27 into master will increase coverage by 57.36%. The diff coverage is 49.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #27       +/-   ##
===========================================
+ Coverage     2.8%   60.17%   +57.36%     
===========================================
  Files           1        3        +2     
  Lines         107      231      +124     
===========================================
+ Hits            3      139      +136     
+ Misses        104       92       -12
Impacted Files Coverage Δ
src/wrapper.jl 73.33% <100%> (ø)
src/LibFTD2XX.jl 43.8% <44.89%> (+41%) :arrow_up:
src/util.jl 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfe0102...6dea8de. Read the comment docs.

samuelpowell commented 5 years ago

Drop 0.6 for sure

ReubenHill commented 5 years ago

Ready for review. @samuelpowell do you know how to get codecoverage to update?

samuelpowell commented 5 years ago

@ReubenHill it may be that the configuration scripts are out of date. I would suggest using PkgTemplates.jl to create the files you want with the appropriate options and then graft them into this repo as appropriate.

samuelpowell commented 5 years ago

@ReubenHill will clone and look through in further detail once you've addressed above

samuelpowell commented 5 years ago

Also, I know it's a bit late now, but had you not considered using Clang.jl? See e.g. Spinnaker.jlto see what it does.

ReubenHill commented 5 years ago

Also, I know it's a bit late now, but had you not considered using Clang.jl? See e.g. Spinnaker.jlto see what it does.

I decided learning how to use Clang.jl would take more time than expanding what I had already to cover more functions. In hindsight, that might have been wrong. The majority of this has been adding tests, making more robust and and adding high level stuff.