ReubenHill commented 5 years ago

Corrects the display of version numbers given buy the libversion and driverversion functions.

It turns out that the version number representation displays decimal numbers as though they are hexadecimal. From the documentation for FT_GetLibraryVersion in the D2XX Programmers Guide:

A version number consists of major, minor and build version numbers contained in a 4-byte field (unsigned long). Byte0 (least significant) holds the build version, Byte1 holds the minor version, and Byte2 holds the major version. Byte3 is currently set to zero.

For example, D2XX DLL version "3.01.15" is represented as 0x00030115. Note that this function does not take a handle, and so it can be called without opening a device.

codecov[bot] commented 5 years ago

Codecov Report

Merging #42 into master will increase coverage by 3.38%. The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   60.17%   63.55%   +3.38%     
==========================================
  Files           3        3              
  Lines         231      236       +5     
==========================================
+ Hits          139      150      +11     
+ Misses         92       86       -6

Impacted Files	Coverage Δ
src/LibFTD2XX.jl	`46.46% <0%> (+2.65%)`	:arrow_up:
src/util.jl	`94.11% <100%> (+10.78%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b3f156...13f8c85. Read the comment docs.

samuelpowell commented 5 years ago

Great catch, thanks @ReubenHill

Gowerlabs / LibFTD2XX.jl

Fix version number display #42

Codecov Report