Gowerlabs / lumomat

MATLAB tools and SNIRF export for LUMO
https://www.gowerlabs.co.uk/lumo
MIT License
10 stars 2 forks source link

Fix saturation data for .LUMO files #44

Closed nidadu closed 2 years ago

nidadu commented 2 years ago

Fix the output of channel saturation data depending on LUMO file version

samuelpowell commented 2 years ago

@nidadu thanks, are you able to update the README also?

nidadu commented 2 years ago

@samuelpowell Yes I did, thanks

samuelpowell commented 2 years ago

Do we not need to invert the logic on the earlier .LUMO files?

nidadu commented 2 years ago

It is done - see the referenced line. The name of lf_chvalid suggests that it indicates channels which are valid, hence I invert it only when writing into the saturation matrix which now highlights channels that are saturated or "not valid".

https://github.com/Gowerlabs/lumomat/blob/f639f2a4ec7cb3c581032a1fc7102d0a2cc075e5/%2Blumofile/private/load_lumo_enum.m#L312

samuelpowell commented 2 years ago

Right you are, missed the tilde!

nidadu commented 2 years ago

Thanks!