search

Goyoo / node-k8s-client

kubernetes client of node.js
MIT License
164 stars 59 forks source link

Versionning discrepancies between npm and github #36

Open Overdrivr opened 7 years ago

Overdrivr commented 7 years ago

Currently, the npm version 0.4.14 is 2 patch version ahead of github 0.4.12. I'm guessing versions are manually set before pushing to npm; This should be fixed and eventually automated so that we get consistent versionning across both.

It's a problem for debugging since we cannot know for sure what version of the code hosted on Github is locally installed. And it's also an issue when looking at the sources to fill the documentation gaps.

dkapanidis commented 7 years ago

From reviewing a bit the packaging in npm, the latest two versions (0.4.13 and 0.4.14) are not properly bundled. The index.js was not compiled with the new changes on the .ts files.

How can we automate this? Any references to libraries with automated process? Automation should probably take into account also #35.

Overdrivr commented 7 years ago

If you setup Travis CI for the project, you can tell him to push to npm registry only for tagged commits, only on master branch. Tags can be created through git and pushed or created directly in Github by creating a new release.

Taking #35 into account is then just a matter of properly writing the packaging script ran by the CI.

@junjun16818 I can make a PR if you are interested. Let me know.

shenshouer commented 7 years ago

@Overdrivr Thank you very much and welcome for the PR