Goz3rr / SatisfactorySaveEditor

293 stars 75 forks source link

crash when loading 3.0 save #156

Closed Kynelongtail closed 4 years ago

Kynelongtail commented 4 years ago

log.txt

Kynelongtail commented 4 years ago

3.0.zip doesn't like .sav files so zipped it.

budak7273 commented 4 years ago

Thanks for sending in this save. It contains an InterfaceProperty, which we haven't implemented yet as of version 0.9.2. One of the upcoming releases will support this property; I'll comment here again once we've put out an update that can load your save.

Kynelongtail commented 4 years ago

awesome thanks!

philomelus commented 4 years ago

I can provide a save as well if desired.

budak7273 commented 4 years ago

@philomelus That would be appreciated. It's always good to have more saves to test with.

philomelus commented 4 years ago

Satisfcatory-Saves-20200218.zip

All of the saves in the archive cause 0.9.2 to crash (they are at different times in the same game). I have auto-save set to 15 minutes, so they encompass about an hour of real world time within game.

twigletx commented 4 years ago

Following :-)

GraspGG commented 4 years ago

Experimental_Update3_0.9.2 SaveFile

For testing purposes - current Editor does close itself while loading that SaveGame.

log.txt

Editors log.txt from last try to open the SaveGame.

hardpoorcorn commented 4 years ago

Following as well. Will another sav and log file assist?

robfrawley commented 4 years ago

Interested in progress as well. I can provide anywhere from 1 to 20 v3 save files if desired.

philomelus commented 4 years ago

I can offer help if you want it.

I have looked into the issue, and I wonder if a long term kluge would be to instead of the default case throwing an exception for an unknown record type (or handling the exception), just keep the data for the record that is not understood verbatim. Then when saving, write the record back out as it was when it came in. There is risk here, as it may need to be modified by changes to other records, but obviously there is no way to know that at that time.

In the above solution, there should still be somewhere that the issue is noted - say at the end of the binary read a single message box notifying the user that "unknown record(s) were found, and they will be left unmodified, which may cause issues when saved in their original state."

budak7273 commented 4 years ago

@Kynelongtail 's, @GraspGG 's, and the two of the saves that @philomelus sent (I didn't test the autosaves) load properly after ef9d53f. Expect a new release soon that supports these saves. Thank you all for your help and sending in saves 👍

philomelus commented 4 years ago

I can confirm that my current saves are now editable. Thank you for all the effort!

PS: Works w/Build 115191.

Fatmice commented 4 years ago

Crashes with Build 115191. There is a new build 115661, crashes as well.

Tekcruzer commented 4 years ago

V 0.9.20 Was working fine yesterday. Then today the app opens but when a load save file is initiated the app closes down.

Following this thread.

philomelus commented 4 years ago

The version built from current source works; We are just waiting for an official build post 0.9.2.

Source version works in both 115191 and 115661.

Tekcruzer commented 4 years ago

When will Packaged Release be available (exe)? - Nice job on this by the way!

philomelus commented 4 years ago

When will Packaged Release be available (exe)? - Nice job on this by the way!

I have no idea, and I have nothing to do with it other than reporting what I know. I am in complete agreement, though, fantastic job!

Fatmice commented 4 years ago

When will Packaged Release be available (exe)? - Nice job on this by the way!

I have no idea, and I have nothing to do with it other than reporting what I know. I am in complete agreement, though, fantastic job!

If this is not the 0.9.2 "release" then what is it? https://github.com/Goz3rr/SatisfactorySaveEditor/releases/tag/0.9.2 I used the executable from that tag

Goz3rr commented 4 years ago

I've released 0.9.3 which should resolve the last issues, let me know if you have any further problems