Goz3rr / SatisfactorySaveEditor

293 stars 76 forks source link

Start maximized #52

Closed budak7273 closed 5 years ago

budak7273 commented 5 years ago

Is there a reason we didn't do this earlier?

Goz3rr commented 5 years ago

Because I personally don't like it, maximized is way too big.

A better change would be to remember the last window size set by the user instead, a quick google leads me here: https://stackoverflow.com/a/847761 but I'm not sure what virusek's preference is as to where to save application data.

virusek20 commented 5 years ago

Yeah, I don't think starting maximized is a good idea especially for people with nonstandard screen sizes (UW here), but saving the last window size seems like a great idea. I think we should use the settings file .NET provides for us, I use that for the recently saved files anyways. https://docs.microsoft.com/en-us/dotnet/framework/winforms/advanced/using-application-settings-and-user-settings You basically add in the Width and Height save fields using the VS GUI and then treat them like normal properties + call save on exit.

budak7273 commented 5 years ago

On my 1366x768 screen the window opens with most of the menu items shoved off the screen, which is why I wanted to make this change in the first place. I take it neither of you encounter this issue?

image

CallumCarmicheal commented 5 years ago

I have a 4K Monitor with 100% scaling, this would be massive for my needs. That said, a good middle ground would be adding a options menu where it can be toggled. @budak7273

budak7273 commented 5 years ago

This is turning into a possible feature now, so I am closing this pull request and opening an issue (#59)