search

Gozala / cfx-js

CLI tool for Mozilla Add-on SDK
http://documentup.com/gozala/cfx-js
2 stars 0 forks source link

Almost all entries are type deprecated #2

Open ochameau opened 12 years ago

ochameau commented 12 years ago

Is that expected ? If you run on reddit-panel, with --compatible flag, all entries but chrome, @loader/options and main.js are type: "deprecated".

Gozala commented 12 years ago

Yes it is, because if you look at the module: https://github.com/mozilla/addon-sdk/blob/master/examples/reddit-panel/lib/main.js#L5-7 there is only two module requirements self and panel and both are found in the addon-skd/packages/* which is considered deprecated. Non deprecated modules will be either in node_modules or will be relative or addon-sdk/lib or in runtime.

P.S.: Deprecated modules have sort of subtype in a warning.type field which can be used to write specific deprecation warning with upgrade instructions

ochameau commented 12 years ago

It's not only about addon module entries, absolutely all entries are deprecated.

So what about this one: https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/system/events.js#L8

  "..\\..\\packages\\api-utils\\lib\\system\\events": {
    "type": "deprecated",
    "path": "..\\..\\packages\\api-utils\\lib\\system\\events.js",
    "id": "..\\..\\packages\\api-utils\\lib\\system\\events",
    "requirements": {
      "chrome": "chrome",
      "../xpcom": "..\\..\\packages\\api-utils\\lib\\xpcom",
      "../heritage": "..\\..\\packages\\api-utils\\lib\\heritage",
      "../namespace": "..\\..\\packages\\api-utils\\lib\\namespace"
    }
  },
  "..\\..\\packages\\api-utils\\lib\\xpcom": {
    "type": "deprecated",
    "path": "..\\..\\packages\\api-utils\\lib\\xpcom.js",
    "id": "..\\..\\packages\\api-utils\\lib\\xpcom",
    "requirements": {
      "chrome": "chrome",
      "./utils/object": "..\\..\\packages\\api-utils\\lib\\utils\\object",
      "./heritage": "..\\..\\packages\\api-utils\\lib\\heritage",
      "./uuid": "..\\..\\packages\\api-utils\\lib\\uuid",
      "./unload": "..\\..\\packages\\api-utils\\lib\\unload",
      "./runtime": "..\\..\\packages\\api-utils\\lib\\runtime",
      "./xul-app": "..\\..\\packages\\api-utils\\lib\\xul-app"
    }
  },
Gozala commented 12 years ago

Well I relative modules to deprecated one will be deprecated to as it's in the packages/api-utils/lib too. Although if you notice this one has no warning field which means it was required properly but still is in the part of graph that is deprecated. I think it would make sense to chat about this stuff live!