search

Gozala / querystring

Node's querystring module for all engines.
MIT License
287 stars 72 forks source link

add escape/unescape per http://nodejs.org/api/querystring.html #7

Closed Trott closed 7 years ago

Trott commented 10 years ago

add escape() and unescape() + minimal tests to show that they work as expected and (per the NodeJS documentation) can be overridden

This issue has been mentioned at: https://github.com/Gozala/querystring/issues/6 https://github.com/mike-spainhower/querystring/issues/4 https://github.com/substack/node-browserify/issues/826

medikoo commented 9 years ago

@Trott Browserify relies on querystring-es3, so any fix here wouldn't fix issue over there.

Also discussion about inconsistency with node is handled now at #6

mike-spainhower commented 9 years ago

I will happily merge updates from this repo into https://github.com/mike-spainhower/querystring if they happen to be ES3 compatible. Anything incompatible would be handled separately via issue or PR in the fork.

dy commented 9 years ago

This issue seems to have long consequences, see https://github.com/mike-spainhower/querystring/issues/4

medikoo commented 9 years ago

@dfcreative issue you meantion is about querystring-es3 (not this project) being incompatible with node. querystring-es3 is different project maintained by different person.

dy commented 9 years ago

@medikoo the owner refers to your repository as a source of incompatibility

medikoo commented 9 years ago

@dfcreative owner then should rely on Node.js and not this package

medikoo commented 9 years ago

@dfcreative incompatibility discussion you linked, is actually a different matter, and it's not related to how querystring natively works in Node.js, it's about incompatibility with one of the goals of Browserify, read carefully linked issue.

ceremcem commented 7 years ago

...and I think this issue is related with this pull request too.

nickpeihl commented 7 years ago

If we ignore the incompatibilities with Browserify, is there anything that is keeping this from being merged?

SpainTrain commented 7 years ago

FWIW I just updated the es3-compatible version and will be publishing it shortly behind a major bump - https://github.com/SpainTrain/querystring-es3

Feel free to review and flag any issues.

medikoo commented 7 years ago

See proposed roadmap: https://github.com/Gozala/querystring/issues/20 it covers also ES3 version, PR's are very welcome (and I will handle them promptly).

I'm going to close it as it all should be addressed with new published versions