Makefile / friendliness. (also bug fix)

Gozala / scratch-kit

Scratchpad for add-on SDK

https://addons.mozilla.org/en-US/firefox/addon/scratch-kit/

15 stars 5 forks source link

Makefile / friendliness. (also bug fix) #4

Closed gregglind closed 12 years ago

gregglind commented 12 years ago

A few small fixes/enhancements.

fixed typo in loader.js
Makefile to build package.json (with pref for addon-sdk enabled)
doc updates

Gozala commented 12 years ago

I'm sorry but these changes no longer make sense in v0.1.0.

loader.js is gone
No need for makefile as one could just use env variable instead of pref.

gregglind commented 12 years ago

I wish I had known there was a new version today :) Thanks for simplifying the code down quite a bit!

Oh well!

On Wed, May 16, 2012 at 5:49 PM, Irakli Gozalishvili reply@reply.github.com wrote:

I'm sorry but these changes no longer make sense in v0.1.0.

loader.js is gone

No need for makefile as one could just use env variable instead of pref.

Reply to this email directly or view it on GitHub: https://github.com/Gozala/scratch-kit/pull/4#issuecomment-5754197

Gozala commented 12 years ago

@gregglind Closing this one down, feel free to reopen if you think it's still relevant.

And thanks for the patch!!

Gozala commented 12 years ago

I wish I had known there was a new version today :) Thanks for simplifying the code down quite a bit!

Sorry for that, I had no idea someone was planning to contribute :) In a future I'll try to create bugs before doing further changes to avoid such situations ;)