search

Gozala / web-encoding

TextEncoder and TextDecoder APIs from Encoding Standard APIs in a universal package
10 stars 6 forks source link

React Native support #13

Closed somay closed 3 years ago

somay commented 3 years ago

resolve #9

You can test it by cloning the repository below.

https://github.com/somay/react-native-web-encoding-compatibility-test

somay commented 3 years ago

Ah, I forgot to write automated test. It'll take some time so I convert this PR to draft now.

somay commented 3 years ago

@Gozala I've wrote up test code. Could you review my patches?

I add jest to devDeps as a testing framework for testing the React Native code.

I understand that it is redundant to having three testing frameworks in one project, but IMHO using mocha also for testing RN code adds more burdens for maintainers because jest is dominating in the React Native testing ecosystem and resources about using mocha for testing RN projects seems very limited and outdated.

somay commented 3 years ago

@Gozala @mirceanis Thank you for reviewing & merging!