search

GrKoR / esphome_aux_ac_component

ESPHome component for AUX based air conditioners. Direct wifi control of HVAC by ESPHome and Home Assistant. HVAC status and command feedback are available.
Other
177 stars 42 forks source link

Make optimistic mode configurable #77

Closed bogdal closed 1 year ago

bogdal commented 1 year ago

This PR makes optimistic mode configurable.

Currently the entity states are updated immediately after receiving a command from Home Assistant/ESPHome. It works in optimistic mode, and there is no guarantee that AC actually is in the expected state. To have more control we should be able to disable this mode and allow only AC to update those states by itself.

PR is backward compatible, by default the logic is the same as now.

Example minimal config to disable optimistic mode:

...
climate:
  - platform: aux_ac
    name: $upper_devicename
    optimistic: false
GrKoR commented 1 year ago

Hey, Adam It looks great and reasonable :) I asked in the telegram chat to test your changes. When tests are passed I'll merge PR into the master. Thank you!

bogdal commented 1 year ago

Awesome, thanks for the heads up.

arsenal3008 commented 1 year ago

ап пишет ошибку, что не так делаю?

GrKoR commented 1 year ago

@arsenal3008 Думаю, с подключением ветки что-то не так.

сделай так:

external_components:
  - source:
      type: git
      url: https://github.com/bogdal/esphome_aux_ac_component
      ref: optimistic-mode

Я видимо что-то спутал и esphome не может подключать PR, только бранчи.

arsenal3008 commented 1 year ago

@arsenal3008 Думаю, с подключением ветки что-то не так.

сделай так:

external_components:
  - source:
      type: git
      url: https://github.com/bogdal/esphome_aux_ac_component
      ref: optimistic-mode

Я видимо что-то спутал и esphome не может подключать PR, только бранчи.

ок, завелось

GrKoR commented 1 year ago

@bogdal Thank you for your PR