GraFiddle / angular-chart

AngularJS directive for adjustable dynamically updating c3 charts
http://grafiddle.github.io/angular-chart/
MIT License
127 stars 40 forks source link

Added support for y2 Axis (label, min, max) and y Axis min, max. #52

Closed ulilicht closed 9 years ago

ulilicht commented 9 years ago

Hi Max,

below you can find a PR for better support of y2 axis.

Have a good week ;-)

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.31%) to 99.69% when pulling 2803bbf9da266f96512e32017418fda2ea817094 on ulilicht:develop into ba24c4d0a8e51c4c6a1849c9e6c5c8db6978e121 on maxklenk:develop.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.7% when pulling 0c6c93e8473b065885c3a5687eb0f1bd48330db0 on ulilicht:develop into ba24c4d0a8e51c4c6a1849c9e6c5c8db6978e121 on maxklenk:develop.

ulilicht commented 9 years ago

HI, i've added another commit to set the displayFormat values of yAxis, y2Axis and the tooltip.

Do you have any other plans with #44 and #43 ? That would fix it at least so far.

Do you have any hint why the coverage from the first commit decreased? I cannot find the position which would not be covered. How can I check the coverage locally? Unfortunately, grunt coverage fails with

Running "karma:coverage" (karma) task
INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser Chrome
INFO [Chrome 40.0.2214 (Linux)]: Connected on socket AL6S7LFkwOssk-DyNDc1 with id 69159886

Running "coveralls" task
[warn] "2015-01-30T09:38:25.998Z"  'Repo token could not be determined.  Continuing without it.This is necessary for private repos only, so may not be an issue at all.'
Fatal error: Bad response:422 {"message":"Couldn't find a repository matching this job.","error":true}
coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.88%) to 99.12% when pulling c643481c0dbb02deb9dda4e2dcd8ad9d30285438 on ulilicht:develop into ba24c4d0a8e51c4c6a1849c9e6c5c8db6978e121 on maxklenk:develop.

maxklenk commented 9 years ago

Hey Uli,

thank you for contributing. Your added configuration options are definitely needed and I will add them for now. In the long run I would like to get closer to the c3.js configuration to transform the angular-chart options object easier and for all configuration parameters.

The grunt task coverage is actually used to upload the coverage report to coveralls. Sorry for the bad naming. The report itself is created on each test run and can then be found in the coverage folder inside the project.

ulilicht commented 9 years ago

ah, thank you very much!

will fix the coverage with my next contribution ;-)

If I find time, I'll think about ways to map all properties.