No Granite No Install - Githubissues

Grabli66 / simple-translate

A simple translation app for Ubuntu and other Linux distributions

http://orschiro.github.io/simple-translate

GNU General Public License v3.0

5 stars 2 forks source link

No Granite No Install #1

Closed JerryCasiano closed 8 years ago

JerryCasiano commented 8 years ago

Remove libgranite dependency
Allow running from build directory

This probably should have been two separate requests, since you may want the Settings changes while keeping libgranite, however, since libgranite is hardly even used, it's a pointless dep anyway.

You can always just copy that one function into the project instead of requiring libgranite.

Figured I would push these changes back before my branch deviates to far to be useful. Having a little fun with it for now.

orschiro commented 8 years ago

Thank you so much for your contribution @JerryCasiano! :smiley:

@Grabli66 what do you think of the discussion around Granite?

Should we keep it or ditch it?

Thankfully,

~Robert

Grabli66 commented 8 years ago

I think that we could remove granite, cause it's "elementary os" lib. After work, i'll check changes and if all fine i'll merge sources.

orschiro commented 8 years ago

Great, thanks @Grabli66! :+1:

~Robert

JerryCasiano commented 8 years ago

Line 37 contains some crack...

@CMAKE_INSTALL_PREFIX@ needs to be changed to your schema ID

Sorry, but my working copy is a mess, missed that when I manually backported these changes.