search

Grabli66 / simple-translate

A simple translation app for Ubuntu and other Linux distributions
http://orschiro.github.io/simple-translate
GNU General Public License v3.0
5 stars 2 forks source link

Cleanup? #10

Closed JerryCasiano closed 8 years ago

JerryCasiano commented 8 years ago

I was a little hesitant on this pull request because it doesn't really do much other than cleanup? but it does introduce a lot of changes which might be improvements or not.

However, with summer here, I haven't really had much free time lately so rather than let this sit on my hard drive for another month or two I figured I'd share it now in case these changes are interesting.

JsonWebClient is just AsyncTaskExecuter and WebJsonClient rolled into one, it should be almost identical both in logic and performance but easier to inherit from.

Changeset seems to work well here, but should definitely see more testing.

orschiro commented 8 years ago

Wow, this looks like a substantial improvement to me.

I myself am hesitant to merge this to not break things.

@Grabli66 are you able to merge this?

Thankfully,

~Robert

Grabli66 commented 8 years ago

Ok. I'll merge

2016-06-02 7:10 GMT+03:00 Robert Orzanna notifications@github.com:

Wow, this looks like a substantial improvement to me.

I myself am hesitant to merge this to not break things.

@Grabli66 https://github.com/Grabli66 are you able to merge this?

Thankfully,

~Robert

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/orschiro/simple-translate/pull/10#issuecomment-223190860, or mute the thread https://github.com/notifications/unsubscribe/AH4vbFOQpR5g1WooDKEU7ObuFzblnun5ks5qHle5gaJpZM4IsIXa .