search

GraceAbike / Portfolio

This is a responsive portfolio website that outlines my professional experience and projects I have worked on. Built using JavaScript, HTML, & CSS.
2 stars 0 forks source link

Peer To Peer Review #10

Open Maxwell011 opened 1 year ago

Maxwell011 commented 1 year ago

This is to review the portfolio

Nedramrez commented 1 year ago

Nice job so far! Especially your animations, they're awesome. Let me kindly suggest you to fix the button's position of your Contacts section at mobile version according to Figma design.
https://github.com/GraceAbike/Portfolio/blob/43cac0c43d0db326ee9381a637dd02da326dc9f8/index.html#L226

GraceAbike commented 1 year ago

@Nedramrez Thanks for your comments.

Hidar37 commented 1 year ago

Some Changes required ♻️ and your are good to merge your pull request:

  • Please add the 500 value in maxlength attribute of your last name input line 213 🤦‍♂️. Because in the requirement of the portfolio project the said your maxlength attribute must have 500 value.👏👏👏
Maxwell011 commented 1 year ago

Wow, amazing so far 👍 Let me kindly suggest you fix the margin space between the heading and the paragraph the margin is too big so kindly reduce it to look like the Figma Design Thanks 👏

GraceAbike commented 1 year ago

@Maxwell011 Thank you for your comments.

GraceAbike commented 1 year ago

@Hidar37 Thank you for the comment.