search

GraceCovenantChurch / gcc_website

Main website for Grace Covenant Church
1 stars 3 forks source link

Changes in yml files #24

Closed joeyzia closed 6 years ago

joeyzia commented 6 years ago

Configurations for Travis setup and AWS env variables for code-deploy

joeyzia commented 6 years ago

THERE IS NO MASTER YET

joeyzia commented 6 years ago

Added fixes

austinEng commented 6 years ago

Also @joeyzia, I think we should make this PR onto the staging branch instead of the develop branch because that's where we'll actually be able to check if it's working.

Can I close this, rebase onto staging, and then make a PR against staging?

austinEng commented 6 years ago

Also @joeyzia sorry for the many requests, but since we're probably going to have tests which are dependent on the Amazon SDK itself with different access restrictions, can we call the env variables in this PR something like TRAVIS_AWS_ACCESS_KEY_ID and TRAVIS_AWS_SECRET_ACCESS_KEY instead?

joeyzia commented 6 years ago

@austinEng - Yeah, I'll close it and then change the configurations to match what you requested. Makes sense the env variables should be more specific.