Closed joeyzia closed 6 years ago
THERE IS NO MASTER YET
Added fixes
Also @joeyzia, I think we should make this PR onto the staging
branch instead of the develop branch because that's where we'll actually be able to check if it's working.
Can I close this, rebase onto staging
, and then make a PR against staging
?
Also @joeyzia sorry for the many requests, but since we're probably going to have tests which are dependent on the Amazon SDK itself with different access restrictions, can we call the env variables in this PR something like TRAVIS_AWS_ACCESS_KEY_ID
and TRAVIS_AWS_SECRET_ACCESS_KEY
instead?
@austinEng - Yeah, I'll close it and then change the configurations to match what you requested. Makes sense the env variables should be more specific.
Configurations for Travis setup and AWS env variables for code-deploy