GraceZhuXY / pe

0 stars 0 forks source link

Similar diagrams for PackCommand and UnpackCommand #9

Open GraceZhuXY opened 1 year ago

GraceZhuXY commented 1 year ago

The sequence diagrams for PackCommand.execute() and UnpackCommand.execute() appear almost identical. There may not be a need for one of the two.

image.png

image.png

nus-pe-bot commented 1 year ago

Team's Response

The purpose of the developer guide is as shown below

image.png

There are distinct differences in the commands called and variables being passed around, these would be useful to a future developer and thus is valid to show any differences between these two distinct commands.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: There are indeed distinct differences, but I think the similarities stand out far more than the differences, which can be easily inferred (especially by a developer and not by a unexperienced user). Hence, though I think it is acceptable for the severity to be downgraded, I also feel that the issue of these diagrams almost being a replicate of each other is quite clear.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]