Grade-Notifier / GN-Core

Stop checking for your grade and just get notified
https://cunysecond.com/GN-Core
MIT License
1 stars 8 forks source link

Added UID to message + moved check user to init #145

Closed Huddie closed 5 years ago

Huddie commented 5 years ago

Added UID to message. Reason for this is now we can hash the username for the logs as well and still allow us to access them given the user reaches out.

Moved the check_user method to init so we can short circuit if the instance exists rather than assuming all is good and having to send a message.

CUNY-Bot commented 5 years ago
1 Error
:no_entry_sign: Oh No! You failed a unit test
Run Python3 ./src/tests/tests.py to see which test failed
..E/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py:643: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=(‘10.100.8.187’, 49339), raddr=(‘128.228.24.52’, 443)>
outcome.errors.clear()
……….
======================================================================
ERROR: test_is_logged_in (main.TestAPIIntegration)
———————————————————————-
Traceback (most recent call last):
File “./src/tests/tests.py”, line 233, in test_is_logged_in
api.login()
File “/usr/local/lib/python3.7/site-packages/cunyfirstapi/cunyfirstapi.py”, line 59, in login
self._password,
File “/usr/local/lib/python3.7/site-packages/cunyfirstapi/login.py”, line 66, in login
encreply = tree.xpath(‘//*[@name=”enc_post_data”]/@value’)[0]
IndexError: list index out of range


Ran 13 tests in 1.602s

FAILED (errors=1)

1 Warning
:warning: 253 PEP 8 issues found
1 Message
:book: Thanks for remembering to declare trivial!

Generated by :no_entry_sign: Danger