search

Gradiant / pyodi

Python Object Detection Insights
https://gradiant.github.io/pyodi/
Mozilla Public License 2.0
189 stars 17 forks source link

add windows support by updating dependency #157

Closed fcakyon closed 3 years ago

fcakyon commented 3 years ago

@mmeendez8 @igonro @cgiraldo thanks a lot for this awesome package!

pycocotools-fix package currently doesnt work on windows: https://github.com/junjuew/cocoapi/pull/4

official pycocotools package is constantly updated by the facebook research team: https://pypi.org/project/pycocotools/

by accepting this pr, pyodi package will be supported on windows.

mmeendez8 commented 3 years ago

Hi @fcakyon!

Thanks for your PR :) I am gonna add a CI build to test pyodi installation on windows and merge this if everything works properly!

mmeendez8 commented 3 years ago

I can see build is crashing with pycocotools-fix https://github.com/Gradiant/pyodi/runs/3348162090

Could you merge your branch with master to use latest workflow so we can check if everything works as expected?

fcakyon commented 3 years ago

@mmeendez8 you mean i should merge in my own fork?

mmeendez8 commented 3 years ago

@mmeendez8 you mean i should merge in my own fork?

Yes, this is a bit annoying https://github.community/t/updating-workflow-file-on-master-and-rerunning-an-action-still-shows-old-workflow-file/18507/10

You can merge your local branch with master and push, that should trigger the latest changes in the workflow

mmeendez8 commented 3 years ago

@fcakyon I just merged it for you! Thanks again for this :)