search

Gradiant / pyodi

Python Object Detection Insights
https://gradiant.github.io/pyodi/
Mozilla Public License 2.0
189 stars 17 forks source link

Remove `logger.catch` decorator #166

Closed mmeendez8 closed 2 years ago

mmeendez8 commented 3 years ago

Close #165

mmeendez8 commented 2 years ago

Why not adding reraise=True arg instead?

I'm not sure if that change would have any advantage so I decided to remove it

daavoo commented 2 years ago

Why not adding reraise=True arg instead?

I'm not sure if that change would have any advantage so I decided to remove it

Just a matter of aesthetics 💅 .

Exceptions caught and raised by loguru provide much more info and just look better. See example (this very simple example is not that useful to have extra info, but still better visuals).

With loguru Captura de pantalla 2021-10-29 a las 17 24 15
Without loguru Captura de pantalla 2021-10-29 a las 17 25 17
mmeendez8 commented 2 years ago

Why not adding reraise=True arg instead?

I'm not sure if that change would have any advantage so I decided to remove it

Just a matter of aesthetics nail_care .

Exceptions caught and raised by loguru provide much more info and just look better. See example (this very simple example is not that useful to have extra info, but still better visuals).

With loguru Without loguru

An image is worth 1000 words! I like your argument