GradienceTeam / Community

Share your Presets
GNU General Public License v3.0
50 stars 32 forks source link

Create "Canta Dark" preset #100

Closed qwertychouskie closed 10 months ago

qwertychouskie commented 11 months ago

Based on https://github.com/vinceliuice/Canta-theme

New Preset: Canta Dark

Description

Based on https://github.com/vinceliuice/Canta-theme

Palette

Not sure what this is

Screenshots (optional)

https://i.imgur.com/WTVd1mb.png

Wallpaper

Probably https://github.com/vinceliuice/Canta-theme/blob/master/wallpaper/Canta_wallpaper_01.jpeg or https://github.com/vinceliuice/Canta-theme/blob/master/wallpaper/canta-dark.png or https://github.com/vinceliuice/Canta-theme/blob/master/wallpaper/canta-wallpaper.png but there are a few other wallpapers in this folder too.

Checklist

Before submitting the PR, I checked:

Publication

Thanks for your submission we will review and merge it as quick as possible.

daudix commented 11 months ago

Looks good, the only change I would do is use dark color for @accent_fg_color as currently contrast is very low. And change @accent_color from blue to green as it should be similar colors to @accent_bg_color

qwertychouskie commented 11 months ago

How about #00ce99 for @accent_bg_color? Making the text black doesn't look very good IMHO.

#feac00 is more accurate to the original theme, but since the conversion wasn't perfectly 1:1 anyways due to the differences between GTK3 and 4, I went with the green, which matched other aspects in the original theme better IMHO. (See screenshots: https://github.com/vinceliuice/Canta-theme#screenshots)

daudix commented 11 months ago

If it has better contrast (or at least visible for example in checkbox) the go ahead :)

qwertychouskie commented 11 months ago

Checkboxes look better after the change to a slightly darker green. If it's possible to use a black check but keep white text, that would be the best (that's how the original theme does it) but if that's not possible IMHO the colors are fine how they are now.

daudix commented 11 months ago

Hm, it seems like @accent_color haven't changed, after the fix I will merge

daudix commented 11 months ago

Oops, @view_bg_color also needs to be changed

qwertychouskie commented 10 months ago

@daudix-UFO Everything should be fixed and ready for merge now AFAIK.

daudix commented 10 months ago

LGTM, thanks for fixing all the issues!

qwertychouskie commented 10 months ago

Awesome! I've always found the colors of Canta nicer/easier on my eyes than stock Adwaita Dark, so I'm happy to make it easily accessible for everyone :)