GradienceTeam / Community

Share your Presets

GNU General Public License v3.0

50 stars 32 forks source link

Port Yaru Bark (Light + Dark) #92

Closed asutoshvariar closed 1 year ago

asutoshvariar commented 1 year ago

New Preset: Yaru Bark

The Yaru Bark theme, for use with Gradience.

Description

The Yaru Bark theme, for use with Gradience.

Palette

[x] None

Screenshots (optional)

Wallpaper

Checklist

Before submitting the PR, I checked:

[ ] I've only modified one preset
[ ] I've added the URL to my raw preset in presets.json
[x] I've checked the format of each json files I modified
[ ] (optional) I've added screenshots
[x] The preset name is following preset naming guidelines.

Publication

[x] I want to add my preset in the preset list.

Thanks for your submission we will review and merge it as quick as possible.

daudix commented 1 year ago

Looks nice, but I don't really like the black @card_shade_color, is it like this in ubuntu yaru?

asutoshvariar commented 1 year ago

It's not mentioned in the adw-colors css file. However, default Adwaita does seem to have an alpha value of 0.07. Should that be changed?

daudix commented 1 year ago

I think so

asutoshvariar commented 1 year ago

Actually, looking back through the files (and the default themes), Adwaita Dark has an alpha value of 0.36 and Adwaita (Light) has an alpha value of 0.07, both of which are accurately reflected in the stylesheets. Has there been any change to Ubuntu that adw-colors hasn't reflected?

Sorry about the confusion.

daudix commented 1 year ago

I don't know, usually I leave Adwaita colors if theme doesn't specify them

asutoshvariar commented 1 year ago

I guess this could be a matter of preference or the rounded corners? Might be safe to get a second opinion on this (couldn't find anything related to card_shade_color in the yaru repo).

daudix commented 1 year ago

If there are no mentions of it that likely means they fallback to Adwaita

daudix commented 1 year ago

Alright, I will make tweaks later, merging!