GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.29k stars 48 forks source link

Toast says preset applied but nothing happens #131

Closed abuhuraira0099 closed 2 years ago

abuhuraira0099 commented 2 years ago

Is there an existing issue for this?

What happened?

I installed the app from the latest flatpak release. I made a preset and pressed the apply button and set the theme. A toast message said that the preset was applied. But it did not change anything. Both Libadwaita and adw-gtk3 apps remained as before. I tried it again and again. I tried logging out and in again, but it did not help. I have set permissions for both GTK4 and GTK3 according to the guidance from the Readme page. I also have the Nightly SDK build installed. I also tried deleting the GTK4 config files. I can't figure out what I am missing here.

To Reproduce

  1. Login on a Fedora Workstation 37 Gnome wayland session.
  2. Follow the steps from the readme page.
  3. Download and install the latest Flatpak build from the release page.
  4. Apply a preset to change Libadwaita and adw-gtk3 colors.

Expected behavior

The theme colors should be changed according to my preset. But it did not.

Screenshots

No response

OS

Fedora Linux 37 (Workstation Edition)

Version

0.1.0

Installation method

Other

Additional context

No response

Code of Conduct

GradienceBot commented 2 years ago

Welcome on Adwaita Manager. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible.

LyesSaadi commented 2 years ago

Same when building from source on Fedora Rawhide (so 37 for now).

0xMRTT commented 2 years ago

Is the change applied on gtk4+libadwaita apps only or didn't apply at all ?

0xMRTT commented 2 years ago

Try to clone the repo and run make local

0xMRTT commented 2 years ago

When applied the preset, did you checked apply as dark theme if you are using the dark theme ?

0xMRTT commented 2 years ago

image

LyesSaadi commented 2 years ago

Hello!

It didn't apply at all. I did check the Apply as Dark Theme. make local fails to apply anything as well. And, I get nothing in the terminal logs.

0xMRTT commented 2 years ago

Corrected in main

0xMRTT commented 2 years ago

Try

git clone https://github.com/AdwCustomizerTeam/AdwCustomizer
cd AdwCustomizer
make local

Should work

LyesSaadi commented 2 years ago

Indeed ! Thanks ! You can close this !

0xMRTT commented 2 years ago

No problems, you are welcome. Feel free to open any others issue or post feedback in Github Discussions or in Chat on Matrix

abuhuraira0099 commented 2 years ago

Is the change applied on gtk4+libadwaita apps only or didn't apply at all ?

Mine did not apply at all.

abuhuraira0099 commented 2 years ago

When applied the preset, did you checked apply as dark theme if you are using the dark theme ?

I tried both with the button enabled and disabled. I also tried changing the global from the Gnome quick settings.

0xMRTT commented 2 years ago

Hi @abuhuraira0099 .

Which version are you using ?

Because the problem is oy resolved in theian branch with meson build

abuhuraira0099 commented 2 years ago

Which version are you using ?

I am now trying with 0.1.0 built it with flatpak-build command. I couldn't compile with meson as it says I don't have the blueprint dependency. I couldn't find a package for this in the fedora or rpmfusion repo. I tried running the pip install... command from the readme to install deps, but it said all deps are installed. I don't know what to do.

0xMRTT commented 2 years ago

But with which version did you tried the first time?

abuhuraira0099 commented 2 years ago

But with which version did you tried the first time?

It was the prebuilt Flatpak from the 0.1.0 release page. They have minor UI differences, but none of them are working.

0xMRTT commented 2 years ago

Did you tried with the flatpak from GitHub Actions ?

abuhuraira0099 commented 2 years ago

Can you please refer to which build I should try? I tried 48ca2c1 right now, but it's still not working.

0xMRTT commented 2 years ago

I was referring to this commit.

Sorry,but I can't do anything for now. I'll try to improve GitHub CI soon.

(The only way is to build from sources)

abuhuraira0099 commented 2 years ago

Sorry,but I can't do anything for now. I'll try to improve GitHub CI soon.

(The only way is to build from sources)

Take your time. It's not something super important. I guess I will wait for now. I was excited to try it though.

daudix commented 2 years ago

I reopen it for now

daudix commented 2 years ago

In my system everything works in latest build

abuhuraira0099 commented 2 years ago

In my system everything works in latest build

Okay I will try and report it back.

abuhuraira0099 commented 2 years ago

Okay I will try and report it back.

Still no success. I guess something is wrong at my setup. But other theming method (like Material You Theme extension and adw-colors) work fine.

0xMRTT commented 2 years ago

I think that's related to Flatpak

abuhuraira0099 commented 2 years ago

I think that's related to Flatpak

Here is my flatpak filesystem permission ss: Screenshot from 2022-08-17 11-22-07

0xMRTT commented 2 years ago

Tried with a local Flatpak build and it works