search

GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.3k stars 47 forks source link

bug: local builds doesn't work #377

Closed tfuxu closed 2 years ago

tfuxu commented 2 years ago

Is there an existing issue for this?

What happened?

This is a pretty old bug, as local builds doesn't work since we changed installation location to PY_INSTALLDIR. As on how to resolve this, we have two options:

We can base a second option on what is in GNOME Music or Apostrophe.

To Reproduce

No response

Expected behavior

No response

Screenshots

Zrzut ekranu z 2022-09-10 14-07-36

OS

No response

Version

0.2.2-main

Installation method

Manual using meson - main

Additional context

No response

Code of Conduct

0xMRTT commented 2 years ago

I know. It's because of your old locales build.

In fact:

You build and when you re build you don't delete old build but just overwriting some files.

I've got this error and when I reinstalled my computer the error disappeared maybe try to remove all local installed files related to gradience

tfuxu commented 2 years ago

I know. It's because of your old locales build.

In fact:

You build and when you re build you don't delete old build but just overwriting some files.

I've got this error and when I reinstalled my computer the error disappeared maybe try to remove all local installed files related to gradience

Really? I'll check that, fortunately I'm doing this on VM so it should be only a snapshot revert for me.

0xMRTT commented 2 years ago

You develop in a VM ?

tfuxu commented 2 years ago

No, I'm just testing Gradience in a VM

0xMRTT commented 2 years ago

Compatibility should be fixed now

tfuxu commented 2 years ago

Updated screenshot to show a reported bug

0xMRTT commented 2 years ago

We must keep installation in PY_INSTALLDIR because of plugins.

tfuxu commented 2 years ago

Ok, we have some progress. I've got it to work, and it shouldn't even require modifying any of a installation instructions. Here are the screenshots: Zrzut ekranu z 2022-09-12 21-27-06

Zrzut ekranu z 2022-09-12 21-30-34 Unfortunately Gradience still has the same problem with icons as before, but for testing purposes, I think it isn't that big of a deal. The exciting part is that translations are now fully working on local builds.

0xMRTT commented 2 years ago

Cool, what did you do ?

tfuxu commented 2 years ago

I modified meson structure a little bit, and renamed src directory to gradience so it can properly import modules. I'll create a PR for this, so don't close this issue for now.

0xMRTT commented 2 years ago

Okay 👌.

tfuxu commented 2 years ago

Fixed in pull request #400