search

GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.3k stars 48 forks source link

Firefox_gnome_theme plugin doesn't correctly theme the Firefox Gnome Theme #523

Closed Raubion closed 1 year ago

Raubion commented 1 year ago

Is there an existing issue for this?

What happened?

After the great 0.3.0-1 update with the plugin to theme Firefox Gnome Theme, I reapplied my custom color scheme. Upon opening the browser, I noticed that the buttons to close (both window and tab), minimalise en maximise are the wrong colour, even though regular gtk4 and gtk3 apps are themed correctly. The ones currently applied are for a light theme, whereas my color scheme is a dark scheme. Changing the light or dark theme in Settings doesn't change this.

I also noticed I couldn't revert back and that reapplying the defaults would keep the Firefox Gnome Theme in the current colors. Upon use, I also noticed that some dropdown menus are transparent, which they weren't before. So I'm thinking this is related.

To Reproduce

  1. Go to gradience, apply theme with Firefox_gnome_theme plugin enabled
  2. Go to Firefox
  3. Notice wrong color buttons.

Important: I cannot currently reproduce because Gradience won't override the current color scheme

Expected behavior

The expected behavior is to correctly apply the color scheme, particularly the correct buttons. The transparent dropdown menus should also not be there

Screenshots

Schermafdruk van 2022-09-27 12-25-42

Schermafdruk van 2022-09-27 12-19-08

Schermafdruk van 2022-09-27 12-18-40

OS

Arch Linux

Version

0.3.0-1

Installation method

AUR

Additional context

No response

Code of Conduct

0xMRTT commented 1 year ago

It's fixed now.

Raubion commented 1 year ago

So I waited for the next release, am now running 0.3.1-2. And in the meantime I also installed the firefox-gnome-theme release 105 which just came out two days ago, but still Gradience won't theme my firefox. I don't see other issues regarding this problem, so is it something in my setup? When I have the plugin enabled and I set any theme, it fully changes both libadwaita and gtk3 apps, but not the firefox theme.

Any tips?

daudix commented 1 year ago

I have this issue too, it will be fixed soon (I hope so)

Raubion commented 1 year ago

Might be related to the #626 commit regarding multiple profiles. In that case it would be fixed soon, as it is merged.