GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.3k stars 52 forks source link

bug: [gtk4.9] Gtk.CssProvider.load_from_data() takes exactly 3 arguments (2 given) #722

Open myyc opened 1 year ago

myyc commented 1 year ago

Is there an existing issue for this?

What happened?

this is mostly a heads-up. it seems that gtk 4.9 introduces a change in Gtk.CssProvider.load_from_data that among a few things, breaks gradience. there is an open MR on pygobject referencing this but i don't really know how their schedules work, if it doesn't get merged in time for 4.10 maybe you need to make a change. either way, from my testing, the fix is trivial and it only affects one line in the entire project.

To Reproduce

  1. have latest (4.9, unstable) gtk installed
  2. start gradience

Expected behavior

No response

Screenshots

No response

OS

Arch Linux

DE/WM version

GNOME 44 beta

Version

main

Installation method

AUR

Enabled system extensions (GNOME specific)

No response

Additional context

No response

Code of Conduct

github-actions[bot] commented 1 year ago

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

tfuxu commented 1 year ago

Thanks for the heads up! We'll be definitely looking into that, as it will unfortunately break compatibility with older GTK4 releases if they don't merge this in time.

0xMRTT commented 1 year ago

Fixed!

tfuxu commented 1 year ago

Reopening for now, as if the MR gets merged in pygobject's repo before stable GTK 4.10 release, we won't need that workaround.