GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.3k stars 48 forks source link

⚠️ Shell Engine Roadmap (see for list of bugs) #763

Open tfuxu opened 1 year ago

tfuxu commented 1 year ago

Feature description

The list below shows features that needs to be implemented to make Shell Engine fully "feature-complete". Items in "Issues" list should be all checked out before 0.8.0 release.

Roadmap:

Issues:

Additional Context

There is a Nightly Flatpak Repo available here for trying and reporting bugs of the upcoming Gradience version

Did you read the Code of Conduct?

V-Mann-Nick commented 1 year ago

Thank you very much for the awesome work. I'm already using the shell engine and it looks really great. I really only noticed one minor thing: the dropdown in the quick settings have default color.

Screenshot ![image](https://user-images.githubusercontent.com/47660390/236888576-0fd12a2c-9fac-4fa9-9903-90bbb5a5d5a9.png)
tfuxu commented 1 year ago

Thank you for your kind words! The issue you described here is the first item in issues list, I'll try to fix it as soon as I have some free time this week.

V-Mann-Nick commented 1 year ago

Perfect. Appreciate it a lot. Sorry for my redundant comment.

0xMRTT commented 1 year ago

Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

tfuxu commented 1 year ago

Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

Fixed in 1a5b1f4. We already have a function to handle that, it was just buggy.

sidevesh commented 1 year ago

@tfuxu Can we add touch keyboard keys to this ? The keyboard background allready uses the theme colors, only the keys need to be adapted. image

0xMRTT commented 1 year ago

@sidevesh yes it should be possible

https://gitlab.gnome.org/GNOME/gnome-shell-sass/-/blob/master/widgets/_keyboard.scss#L33

tfuxu commented 1 year ago

@tfuxu Can we add touch keyboard keys to this ? The keyboard background allready uses the theme colors, only the keys need to be adapted. image

Sure, we can add it to the list

0xMRTT commented 1 year ago

got it, it's already possible :)

0xMRTT commented 1 year ago

image

$key_bg_color = darken($osd_fg_color, 70%); and osd_fg_color can be set here:

image

I agree that it looks a wrong but the idea is here :). It will require a bit more customization for having the background

0xMRTT commented 1 year ago

without any tweaks, just by using the Catpuccin Mocha preset I got :

image

:warning: you need to use nightly for having the Shell theming feature

tfuxu commented 1 year ago

Great, first one off the list :ballot_box_with_check:

0xMRTT commented 1 year ago

@tfuxu I'm going to fix them soon. (this one wasn't an issue ... It was just available but unused by @sidevesh)

sidevesh commented 1 year ago

@0xMRTT I don't see where I can add these options, I see osd_fg_color already there in that list but not key_bg_color, and I don't see how I can add it

0xMRTT commented 1 year ago

@sidevesh That's because there isn't key_bg_color osd_fg_color do the job. Have a look at the catpuccin Mocha theme!

sidevesh commented 1 year ago

Screenshot from 2023-07-31 19-48-51 Found another issue that started happening recently, the sidebar in Geary seems to not get its color updated anymore, not sure if this happened due to updates to the app or adw-gtk3 theme (Geary is still using gtk3)

sidevesh commented 1 year ago

I couldn't test with newest commits since the arch aur gradience-git package is broken currently and does not build anymore

0xMRTT commented 1 year ago

QS Menu issue has been fixed!

sidevesh commented 1 year ago

@0xMRTT do you have any idea about the Geary sidebar issue I shared above ?

0xMRTT commented 1 year ago

@sidevesh I don't have it...

image

0xMRTT commented 1 year ago

try latest commit maybe (i've fixed the submodule issue)

sidevesh commented 1 year ago

weird, its still happening for me on arch, what theme is that which you have applied ?

0xMRTT commented 1 year ago

@sidevesh i've applied Pretty Purple

sidevesh commented 1 year ago

Yeah, I had tried with that theme too, same issue in geary still, weird

0xMRTT commented 1 year ago

@sidevesh what's your version of geary ?

sidevesh commented 1 year ago

44.0 (tags/44.0-0-gb72db2a5e)

0xMRTT commented 1 year ago

@sidevesh The issue here is that the sidebar is plain (no Gradience, and no adw-gtk3). Can you try removing ~/.config/gtk-3.0/gtk.css, kill geary and see if it's plain adw-gtk3 even for the sidebar. If not, try updating adw-gtk3...

sidevesh commented 1 year ago

@0xMRTT what do you mean its plain ? As in its not themable / hardcoded color or something like that ? I did try with the changes you suggested, not sure what I am looking for

0xMRTT commented 1 year ago

I mean that the colour of the sidebar is the one that the sidebar should have without any theming ?

sidevesh commented 1 year ago

I am not sure what happened but after removing ~/.config/gtk-3.0/gtk.css and then applying theme from gradience, at some point that file got deleted and is not coming back. I tried resetting gtk3 theming and applying themes again but it is not coming back.

sidevesh commented 1 year ago

Looks like gradience is completed borked now :( I can regenerate the gtk.css from Material You shell extension but then applying from Gradience deletes it again. No idea how this happened.

Reinachan commented 1 year ago

Some accent colours make the quick settings look a bit off.

Notice the dark line on the active pills with dropdowns. It ends up oversaturated and looks almost like it's too wide? screenshot of quick settings, themed

This is how the default colours are. As you can see, that line doesn't stick out as much here. screenshot of quick settings, default

I'm using the 0.8.0-beta1 from flathub. Colours are:

Both backgrounds: #0d0d0d
All foregrounds: #ffffff
Accent: #ff8686
inthreedee commented 12 months ago

The sidebar color issue with Geary that was mentioned by @sidevesh above (https://github.com/GradienceTeam/Gradience/issues/763#issuecomment-1660237698) appears to be an upstream adw-gtk3 v4.9 issue, as downgrading to adw-gtk3 v4.8 fixes it. I've reported it here: https://github.com/lassekongo83/adw-gtk3/issues/240

0xMRTT commented 12 months ago

@inthreedee This issue is part of the new Libadwaita 1.4 widgets (sidebar and secondary sidebar). You can configure this vars with Gradience nightly

image

ParaSpl01t commented 9 months ago

Is shell theming available in GNOME 45.2 right now? I'm using gradience-git 0.8.0.beta1.r96.gab70ed87-1 from aur Everything works using pretty purple theme except shell gnome shell quick settings.

EDIT: I missed the APPLY button under Shell Engine option in theming tab. everything works now.

manan-gup commented 8 months ago

Hi, I've installed the 0.8.0-beta1-36b91fe flatpak nightly package. I tried applying the shell theme using the apply button in the shell engine section but nothing happened. Tried logging out too to no avail. Can I do anything to troubleshoot this?

daudix commented 8 months ago

@manan-gup do you have "User Themes" extension installed and enabled?

manan-gup commented 8 months ago

Yes I do. Should I disable it?

daudix commented 8 months ago

Nope. Could you check if there are theme with gradience in the name available? If there are one select it

manan-gup commented 8 months ago

image This is what I'm getting. The Sweet* themes have been manually installed.

daudix commented 8 months ago

Hm, odd. Are you sure that you press the right apply button? (you need to press apply that are located in the shell theming section)

manan-gup commented 8 months ago

image Yes, I pressed this one.

daudix commented 8 months ago

Alright, can you launch it from terminal with flatpak run com.github.GradienceTeam.Gradience.Devel and send the output here please

manan-gup commented 8 months ago
Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 59, in __init__
    self._detect_shell_version()
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 326, in _detect_shell_version
    raise UnsupportedShellVersion(
gradience.backend.exceptions.UnsupportedShellVersion: GNOME Shell version 45 is not supported. (Supported versions: 42, 43, 44)

Oh, my bad. I didn't know that Gnome 45 is not supported. It would be nice to get this message in the UI as well.

daudix commented 8 months ago

Hm, it should be, try this build: https://github.com/GradienceTeam/Gradience/actions/runs/7214048889/artifacts/1115721706

manan-gup commented 8 months ago

Hm, it should be, try this build: https://github.com/GradienceTeam/Gradience/actions/runs/7214048889/artifacts/1115721706

It worked with this build. Thanks!

daudix commented 8 months ago

You're welcome ^^

CaragC commented 8 months ago

Using this build, when clicking the apply button next to "Shell Theming Options", nothing happens. The console prints out the following when running flatpak run com.github.GradienceTeam.Gradience.Devel

[Gradience] DEBUG: Spawning: ['flatpak-spawn', '--host', 'gnome-shell', '--version']

** (gradience:2): WARNING **: 15:59:06.037: Failed to load shared library 'libportal.so.1' referenced by the typelib: /app/lib/libportal.so.1: undefined symbol: g_once_init_leave_pointer
/app/lib/python3.11/site-packages/gradience/backend/globals.py:98: Warning: cannot retrieve class for invalid (unclassed) type 'void'
  portal = Xdp.Portal()
Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 75, in __init__
    settings_retriever = FlatpakGSettings if is_sandboxed() else GSettingsSetting
                                             ^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/globals.py", line 98, in is_sandboxed
    portal = Xdp.Portal()
             ^^^^^^^^^^^^
TypeError: could not get a reference to type class

Is there anyway to fix this?

daudix commented 8 months ago

@CaragC do you have User Themes extension installed? it is needed for the shell theming to work

CaragC commented 8 months ago

Yes it is installed and does not show any Gradience themes. The second theme I installed myself. image