GradienceTeam / Gradience

Change the look of Adwaita, with ease
https://gradienceteam.github.io
GNU General Public License v3.0
1.3k stars 47 forks source link

bug: inconsistent theming on top bar #899

Open directorscut82 opened 3 months ago

directorscut82 commented 3 months ago

Is there an existing issue for this?

What happened?

Top row does not seem to apply the theme I choose from Grandience. As you can see on the left the windows appear correct (I choose 'pretty purple'), but the menus of the top bar have not changed (previous blue theme is still loaded).

To Reproduce

Choose whichever theme from Grandience's library and hit apply.

Expected behavior

All GUI elements should appear with the same theme.

Screenshots

desktop image

OS

ubuntu 24.04

DE/WM version

gnome 46

Version

0.4.1

Installation method

Flatpak from Flathub

Enabled system extensions (GNOME specific)

No response

Additional context

Please note that the blue theme was selected before I updated my ubuntu from 23.10 to 22.04 but for some reason is 'stuck'. I have reverted to original settings according to the manual instructions before reinstalling Grandience, after the update. Shell is selected as 'Grandience' (as you can see from the image too) and whenever I chose it, it sets this blue theme instead.

Code of Conduct

github-actions[bot] commented 3 months ago

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

sixpounder commented 3 months ago

I suspect this is related to how latest versions of libadwaita theme certain widgets

I solved it with a temporary hack using a custom css additions (in the advanced panel)

toolbarview {
    background-color: @view_bg_color;
    color: @view_fg_color;
}

toolbarview headerbar {
    background-color: @view_bg_color;
    color: @headerbar_fg_color;
}

Please note this might not work for everything and might break something else but, ehi, it is broken already :)

directorscut82 commented 3 months ago

thanks for the hint but unfortunately the old blue theme is still stuck:) edit: though the most funny thing is that in 24.04 it is the first time ever in my setup the theme is applied correctly to Firefox

Tropix126 commented 3 months ago

Here's a temporary (and technically incomplete) fix via Custom CSS for those on GNOME 46 (LibAdwaita 1.4):

@define-color sidebar_bg_color @card_bg_color;
@define-color sidebar_fg_color @card_fg_color;
@define-color sidebar_shade_color @shade_color;
@define-color sidebar_border_color @headerbar_border_color;
@define-color sidebar_backdrop_color @headerbar_backdrop_color;

This is kind of a bit of a hack, since it just reassigns new variables to existing ones, but ideally these should be separately configurable similar to headerbar colors.

image

There are also more named colors for secondary sidebars, so I might update this snippet later. Anyways, the main thing here is that there are new color variables present in libadwaita specifically for sidebars and secondary sidebars.

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1-latest/named-colors.html#sidebar-colors image

Furthermore there's now @popover_bg_color, @popover_fg_color, and popover_shade_color for GtkPopover.

directorscut82 commented 3 months ago

Hi, thank you for the CSS and the explanation, but it is still stuck. I applied it for every possible combination, gtk3 & gtk4 options: Screenshot from 2024-06-19 17-08-00

directorscut82 commented 3 months ago

just noticed that I got an improvement though: image

The left panel of Nautilus (and other windows too) were always white no matter the theme. Now, at least they have the correct color:)

Tropix126 commented 3 months ago

@directorscut82 could I get a screenshot of an app with an unthemed sidebar?

directorscut82 commented 3 months ago

@Tropix126 you can see it in the first screenshot I posted, 'Display settings' left panel is white instead of purple