GradleUp / shadow

Gradle plugin to create fat/uber JARs, apply file transforms, and relocate packages for applications and libraries. Gradle version of Maven's Shade plugin.
https://www.gradleup.com/shadow/
Apache License 2.0
3.69k stars 389 forks source link

Documentation says `destinationDir` which has been changed for `destinationDirectory` #925

Closed cyrhi closed 1 month ago

cyrhi commented 2 months ago

Thank you for the plugin!

Easy fix: revert to destinationDir or update the documentation for destinationDirectory. Not sure this change was worth breaking compatibility. I had to search the source code.

Shadow Version

8.1.1

Gradle Version

8.8

Expected Behavior

destinationDir works.

Actual Behavior

Could not set unknown property 'destinationDir' for task ':myProject:myTask' of type com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar.`

Gradle Build Script(s)

task myTask(type: ShadowJar) {
    configurations = [project.configurations.myConfiguration]
    destinationDir = file("myFolder")
}
Goooler commented 2 months ago

Thanks for this report! Addressing the fix in #876.