search

GradleUp / shadow

Gradle plugin to create fat/uber JARs, apply file transforms, and relocate packages for applications and libraries. Gradle version of Maven's Shade plugin.
https://www.gradleup.com/shadow/
Apache License 2.0
3.77k stars 396 forks source link

Apply an empty `com.github.johnrengelman.shadow` plugin to simplfy migration to the new plugin id `com.gradleup.shadow` #958

Closed ljacomet closed 2 months ago

ljacomet commented 2 months ago

What feature do you want to see added?

With the rename of this plugin, existing build logic that reacts to the application of the com.github.johnrengelman.shadow plugin will no longer be executed.

If this plugin was applying an empty plugin with this plugin id, the logic would still be executed since currently com.gradleup.shadow is a drop-in replacement for the previous plugin.

The main downside of doing this is that there is no clear path to deprecate and finally remove that behaviour while warning users that may rely on it without realising it as Gradle does not have APIs for this.

Upstream changes

Gradle will be releasing a version of the plugin-publish plugin that accounts for this new plugin id because without it, some plugin publishing opinions are not enforced when applying shadow.

Are you interested in contributing this feature?

If there is agreement to do this, I would be willing to submit a patch for it.

Goooler commented 2 months ago

That sounds good!

Goooler commented 2 months ago

https://github.com/GradleUp/shadow/releases/tag/8.3.1