search

GradleUp / shadow

Gradle plugin to create fat/uber JARs, apply file transforms, and relocate packages for applications and libraries. Gradle version of Maven's Shade plugin.
https://www.gradleup.com/shadow/
Apache License 2.0
3.77k stars 396 forks source link

Plugin jar contains registration for missing Log4J annotation processor #965

Closed marcphilipp closed 2 months ago

marcphilipp commented 2 months ago

Expected and Results

The shadow-gradle-plugin-8.3.1.jar contains a META-INF/services/javax.annotation.processing.Processor file that contains a reference to org.apache.logging.log4j.core.config.plugins.processor.PluginProcessor but the annotation processor is not part of the JAR.

I strongly suspect the plugin jar should not contain a META-INF/services/javax.annotation.processing.Processor file at all.

Related environent and versions

8.3.1

Reproduction steps

This yields to problems when compiling Java classes with the plugin jar on the classpath and not using the -proc:none compiler arg.

Anything else?

No response

Goooler commented 2 months ago

Thanks for the heads-up! This is due to https://github.com/GradleUp/shadow/pull/960#discussion_r1754555359.

Goooler commented 2 months ago

@marcphilipp Could you try out 8.3.2-SNAPSHOT?

marcphilipp commented 2 months ago

The latest snapshot resolves the issue. Thanks for the quick turnaround! :+1:

Goooler commented 2 months ago

Thanks for your report!