search

Graeme22 / tastyworks-cli

Easy to use command line interface for Tastyworks!
MIT License
15 stars 2 forks source link

Added `quantlib_tools` package, test case and command #7

Closed def-mycroft closed 3 years ago

def-mycroft commented 3 years ago

Added a package that provides some helper funcs for QuantLib. There is a test case in for the options model in the quantlib_tools package and a command in the base controller allows for modeling the price of a single option.

Graeme22 commented 3 years ago

Looks good, thanks for adding the test. Let me get a CI pipeline running, then I'll merge this.

def-mycroft commented 3 years ago

cool. I haven't done anything with the cement testing apparatus yet, just that unit test module in core.quantlib_tools.

we might want to talk about the project layout, when I've used cement I organize everything into packages under the "core" folder, seems to work pretty well, but you might have a better idea.

On Thu, May 13, 2021 at 3:12 PM Graeme Holliday @.***> wrote:

Looks good, thanks for adding the test. Let me get a CI pipeline running, then I'll merge this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Graeme22/tastyworks-cli/pull/7#issuecomment-840805241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEY7CLBUVXBMIBVRTJXSEHTTNQXDDANCNFSM443EEJNQ .

-- Joseph Dasenbrock

Graeme22 commented 3 years ago

Hi @def-mycroft, please rebase and add a commit to this, that will trigger the CI test.

Graeme22 commented 3 years ago

Also, please move the code into the twcli/core/quant folder.

def-mycroft commented 3 years ago

hi @Graeme22 , the tests passed, I'm not sure what to do now, do you have to merge the pr? thanks

def-mycroft commented 3 years ago

also @Graeme22 , previously you said "Also, please move the code into the twcli/core/quant folder", should I move the quantlib_tools folder there or the files in quantlib_tools? I tried moving the quantlib_tools folder there, but then the tests didn't run (for that code).

Graeme22 commented 3 years ago

also @Graeme22 , previously you said "Also, please move the code into the twcli/core/quant folder", should I move the quantlib_tools folder there or the files in quantlib_tools? I tried moving the quantlib_tools folder there, but then the tests didn't run (for that code).

I think moving the scripts to the quant folder seems the cleanest.

Notice how at the top of this PR it says "Files changed: 48"? That's no bueno. You need to rebase this with the current master. https://anavarre.net/how-to-rebase-a-github-pull-request/#:~:text=Rebase%20your%20pull%20request&text=First%20things%20first%2C%20we%20need,we%20originally%20created%20the%20PR.&text=Now%2C%20we%20can%20run%20the,top%20of%20our%20development%20branch.&text=The%20last%20remaining%20step%20is,does%20replace%20the%20outdated%20PR.

def-mycroft commented 3 years ago

also @Graeme22 , previously you said "Also, please move the code into the twcli/core/quant folder", should I move the quantlib_tools folder there or the files in quantlib_tools? I tried moving the quantlib_tools folder there, but then the tests didn't run (for that code).

I think moving the scripts to the quant folder seems the cleanest.

Notice how at the top of this PR it says "Files changed: 48"? That's no bueno. You need to rebase this with the current master. https://anavarre.net/how-to-rebase-a-github-pull-request/#:~:text=Rebase%20your%20pull%20request&text=First%20things%20first%2C%20we%20need,we%20originally%20created%20the%20PR.&text=Now%2C%20we%20can%20run%20the,top%20of%20our%20development%20branch.&text=The%20last%20remaining%20step%20is,does%20replace%20the%20outdated%20PR.

I don't see how to rebase with the current master, I get an error invalid upstream... here is a pastebin.

I do already have the latest commit from the main repo in my fork... (30f92c63)

Graeme22 commented 3 years ago

I don't see how to rebase with the current master, I get an error invalid upstream... here is a pastebin.

I do already have the latest commit from the main repo in my fork... (30f92c6)

One thing that might make it easier for you is to just open a new pull request on a branch from the current main and add your changes there.

def-mycroft commented 3 years ago

okay, I'll just close this one then.