Don't check removed transcriptions

GrafeasGroup / blossom

The website. The app. The everything.

6 stars 3 forks source link

Don't check removed transcriptions #137

Closed itsthejoker closed 2 years ago

itsthejoker commented 3 years ago

Relevant issue: https://github.com/GrafeasGroup/tor/pull/215

Description:

The other side of the linked PR. This changes the posts to Slack so that removed transcriptions are never brought up checking.

Checklist:

[x] Code Quality
[x] Pep-8
[x] Tests (if applicable)
[x] Success Criteria Met
[ ] Inline Documentation
[ ] Wiki Documentation (if applicable)

itsthejoker commented 3 years ago

After thinking about it, I'm not happy about this yet. We know from experience that a lot of new volunteers have their transcriptions nuked by the spam filter, and with this as it's written right now, it's possible to skip their first transcription getting posted if it's removed by Reddit. I'm going to rework this a little bit.

TimJentzsch commented 3 years ago

What about posting the transcription text in a code block instead? Once it's marked as done Blossom should have that data, right? Could spam the channel a bit, but if it's only for the removed transcriptions it's probably fine.

itsthejoker commented 2 years ago

I forgot this was a thing. Will address.

itsthejoker commented 2 years ago

I'm only commenting to get the github bot to shut up for a little bit. Currently working on https://github.com/GrafeasGroup/blossom/pull/188