Rework username handling - Githubissues

GrafeasGroup / buttercup

Our personal assistant in Discord

MIT License

5 stars 2 forks source link

Rework username handling #113

Closed TimJentzsch closed 2 years ago

TimJentzsch commented 2 years ago

Relevant issue: Closes #112.

Description:

This is a major rework to simplify the process of validating usernames and getting the user data from Blossom. This has several advantages:

Consistency across all commands.
Reduced code duplication, better error handling.
We get some new features for "free", because we can always handle keywords like me and all for the username.

The /heatmap, /leaderboard and /progress commands can now also take the all keyword to show the stats for the whole ToR community.

After merging this, all commands should be tested extensively to ensure that no formatting key errors or other bugs have sneaked in.

Checklist:

[x] Code Quality
[x] Pep-8
[x] Tests (if applicable)
[x] Success Criteria Met
[x] Inline Documentation
[ ] Wiki Documentation (if applicable)

itsthejoker commented 2 years ago

Hell yeah! Let's get the static analysis fixed and then it's outta here