Relationship circle is not in the center of the line when the ER is moved around

Grafieks-Analytics / grafieks-desktop

Simple business intelligence platform for data democratization

GNU General Public License v3.0

15 stars 4 forks source link

Relationship circle is not in the center of the line when the ER is moved around #79

Open kocharee opened 3 years ago

chilarai commented 3 years ago

Fixed with PR #138

kocharee commented 3 years ago

The relationship icon is not in center when entities are in parallel.

chilarai commented 3 years ago

Cant be fixed 100% because division of pixels with fractions, prime numbers, etc does not lead to perfect results. Also, did you try bringing up any entity very close to another entity or over any entity? For those scenarios, we haven't thought of anything @kocharee

kocharee commented 3 years ago

Sorry, I think we didn't discuss on the second point from the previous comment in today morning's call.

chilarai commented 3 years ago

Ok. As discussed, we will implement dagre.js in the future to mitigate this