Deleting menu link does not remove it's id from menus.order column

[jpranskaitis]

To repeat this issue just create 'main' menu add two links to it, change the sorting of them, delete one link and open a page that shows 'main' menu.

[2018-09-19 13:53:20] local.ERROR: Undefined offset: 4 (View: /public_html/resources/themes/front/partials/navigation.blade.php)

[mlantz]

Will issue a fix as soon as possible

[jpranskaitis]

Thanks.

Also great idea would be to use protected $casts for json operations.

Like:

class Menu extends CmsModel { //... protected $casts = [ 'order' => 'array' ] //... }

Laravel would parse the field for you and you will not need to encode/decode it anywhere. One drawback is that you will not be able to do ->update(['order' => $order_array) directly, but

$menu->order = $order_array; $menu->save();

would work like a charm.

[mlantz]

Will look at making those adjustments, thanks