search

GraftJS / jschan

JavaScript port of libchan based around streams
MIT License
157 stars 9 forks source link

Close & Destroy #32

Closed mcollina closed 8 years ago

mcollina commented 9 years ago

Implemented correctly session.close, session.destroy and channel.destroy.

AdrianRossouw commented 9 years ago

@mcollina How does this affect the websocket driver?

lgtm otherwise

mcollina commented 9 years ago

Not much, it was a bug shared by all transports. I'm trying to fix the closing issue on graft, so that we can have a proper reconnect system on top of that. However that's not solved yet, tests passes here but not there :(.

AdrianRossouw commented 9 years ago

how can i help? it's the next thing i want to tackle in aetherboard. currently it crashes if you close a tab, and anyone draws.

mcollina commented 9 years ago

open a bug there with a stacktrace. Also, a test to reproduce will help a lot!