search

GrahamCampbell / Laravel-Markdown

A CommonMark wrapper for Laravel
https://gjcampbell.co.uk/
MIT License
1.32k stars 139 forks source link

Update deprecated classes Converter and ConverterInterface #142

Closed mmachatschek closed 4 years ago

mmachatschek commented 4 years ago

This updates the deprecated code introduced in league/commonmark:^1.5.

The composer version of league/commonmark has been increased.

I could also target the 2.x release of commonmark if you want.

GrahamCampbell commented 4 years ago

Thanks for this, however this is a major breaking change, as it breaks dependency injection for people using the old classes. That said, that's ok: we can do a major release. I think we will want to bump all the way to ^1.5 for that, and use all of the new stuff, maybe even changing the default flavour. I'll have a closer look at things soon. :)

GrahamCampbell commented 4 years ago

Please don't add .idea to the ignore file. IDE and system files should be added to your global ignore file.

mmachatschek commented 4 years ago

@GrahamCampbell I removed the .gitignore changes and set the minimum version to league/commonmark:^1.5

GrahamCampbell commented 4 years ago

Sorry this is taking me so long to get to. I will look at this today. :)

GrahamCampbell commented 4 years ago

This is great, thanks! 🚀