GrahamDumpleton / mod_wsgi-docker

Docker images for Apache/mod_wsgi.
Apache License 2.0
72 stars 36 forks source link

Get Apache packages from archive.apache.org instead of mirror #23

Closed mandarg closed 7 years ago

mandarg commented 7 years ago

While building an image on top of this using some of the defined environment variables (APR_UTIL_VERSION, etc.), I noticed that the mirror.ventraip.net.au links for the pinned versions are no longer valid, since the mirror only has the latest version.

Hence, I changed the links to point to archive.apache.org which should (hopefully) be stable for much longer.

Also, the images wouldn't build from scratch from the current master, because the rm for /var/lib/apt/lists was failing out with a "No such file or directory." I added a -f to fix that.

Testing: Images built without errors from the build.sh script.

GrahamDumpleton commented 7 years ago

Apache people must have changed their procedures. The archive only used to have old versions and not the latest. It was always really annoying as I couldn't find a stable URL that would always work.

mandarg commented 7 years ago

The archive only used to have old versions and not the latest.

Hm. If that was the case some time in the past, the archive now says “This is simply a copy of the main distribution directory with the only difference that nothing will be ever removed over here.” I verified that it does contain the latest stable releases.

So hopefully downloading the pinned versions from there should be okay, even if they change in the future.

GrahamDumpleton commented 7 years ago

So you know, it is very difficult for me to update the images based on this repo that are on Docker Hub these days. This is because Docker Hub has for a while now blocked building with an automated build, any Dockerfile which tries to run the setcap program even if it is only to allow a program to bind to port 80.

I can make the changes to the repo, but I don't have a simple way of pushing new images to Docker Hub with newer versions of Apache and mod_wsgi. This is because my home Internet connection is too slow. I hesitate in trying to set up some CI service which can do it as this particular image isn't something I really do anything with now as I have better images have been working on and using instead, which aren't restricted from being built by Docker Hub and which use better practices in how they work.

If interested in those images and using then, can maybe drop an email to mod_wsgi mailing list and I can start discussing them there.

GrahamDumpleton commented 7 years ago

Seems Docker Hub may have lifted the restriction on use of setcap. Am updating images to latest versions of everything.

mandarg commented 7 years ago

Perfect, thanks a lot!