search

GrahamDumpleton / wrapt

A Python module for decorators, wrappers and monkey patching.
BSD 2-Clause "Simplified" License
2.06k stars 231 forks source link

Update for fixed outer @classmethod behavior in Python 3.9 #161

Closed mgorny closed 3 years ago

mgorny commented 4 years ago

Hope this helps. If you prefer me to do it another way, just let me know.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.03%) to 94.126% when pulling 33708e76578c173333d1879a4a21baddf8fcdb6a on mgorny:py39-classmethod into 264c06fd3850bd0cda6917ca3e87417b573e023f on GrahamDumpleton:develop.

GrahamDumpleton commented 3 years ago

I must really be asleep at the wheel. Finally got a few days to catch up on wrapt stuff and one of the first things I did was to fix the failing tests due to classmethod changes. I either didn't see this PR when it originally came in, it didn't register what it was, or I totally forgot about it. I only found it after I had knocked off most recently active PR and started looking for next one to work on. :-(

So major apologies that your effort went to waste and I did it myself anyway, although when looking at yours I did realise I had missed one part of docs that needed updating. Hope this doesn't deter you from contributing in the future, it definitely wasn't intentional. Sorry.

mgorny commented 3 years ago

Not a big deal, what matters is that it's fixed (or at least I hope it is, haven't tested yet ;-)).