Travis-ci potential build problems

RussBaz commented 8 years ago

I am sorry for nitpicking but Travis does not seem to be testing 'wrapt' against Python 3.5.x in your current configuration as it is shown in the logs.

Also, one more thing, you can try using 'appveyor' (https://www.appveyor.com/) for windows build testing and it can build windows wheels too (https://packaging.python.org/appveyor/).

Thank you.

GrahamDumpleton commented 8 years ago

I don't know how to use Travis. Someone else supplied the configuration for wrapt to do the testing.

The tox.ini file in wrapt will attempt to test with Python 3.5:

[tox]
envlist =
  py{26,27,33,34,35}-{without,with}-extensions,
  pypy-without-extensions

[testenv]
deps =
  {env:COVERAGE_DEP:}
  pytest
commands =
  {env:COVERAGE_CMD:} py.test -v []
setenv =
  without-extensions: WRAPT_EXTENSIONS = false
  with-extensions: WRAPT_EXTENSIONS = true

[pytest]
norecursedirs = .tox venv

The .travis.yml file does though indicate that back when it was setup Travis didn't support Python 3.5.

language: python
python: 2.7
env:
  global:
    - COVERAGE_CMD="coverage run -m"
    - COVERAGE_DEP=coverage
install:
  - pip install tox coveralls
script:
  # travis lacks python3.5
  - tox --skip-missing-interpreters
after_script:
  - coverage combine
  - coveralls

This though was handled by having --skip-missing-interpreters option to tox.

If Travis has Python 3.5 now, it should work as far as I can tell.

Are you sure the issue isn't that since wrapt has been changed for quite a while, that it isn't simply the case that a test hasn't been triggered since Travis added Python 3.5 support.

I can try manually triggering a new test on Travis, but if that doesn't work, then you will have to indicate what needs to be change to make it work.

As to Windows and wheels, someone did once supply a PR for that:

https://github.com/GrahamDumpleton/wrapt/pull/43

I am not a Windows users and don't know how to use that service either. If you want to try and validate their changes for me, then maybe can look at it again. I will likely still need help to set it up though.

GrahamDumpleton commented 8 years ago

I forced a rebuild on Travis and Travis still says it doesn't have a Python 3.5 interpreter. I don't know how to fix Travis if they now supply Python 3.5 somewhere.

RussBaz commented 8 years ago

Travis-CI is indeed supporting Python 3.5 (https://docs.travis-ci.com/user/languages/python#Choosing-Python-versions-to-test-against) now.

I can have a look at these issues over the weekends if you don't mind.

RussBaz commented 8 years ago

I managed to add missing interpreter to Travis-CI and I also added Appveyor config file for Windows testing.

Please have a look.

GrahamDumpleton commented 7 years ago

Closing this issue. Python 3.5 now being test on Travis and appveyor tests in place as well. Separate PR related to creating binary wheels for Windows still not done though.

GrahamDumpleton / wrapt

Travis-ci potential build problems #87