Grails-Plugin-Consortium / grails-cxf

CXF Plugin for the Grails web framework
http://grails.org/plugin/cxf
38 stars 46 forks source link

Updated plugin to work with Grails 2.4: #40

Closed legart closed 10 years ago

legart commented 10 years ago
ctoestreich commented 10 years ago

Looks like tests are failing. Would love to merge but can we get tests working first?

legart commented 10 years ago

Sorry, it was passing on the machine if was checking in from. Not here though - different java versions. I will have a look!

zyro23 commented 10 years ago

thanks for the pr! looks like travis is happy now, too. can this be merged and released now?

zyro23 commented 10 years ago

bump. this is currently blocking a grails-2.4 upgrade. @legart do you think you could update the pr resolving the merge conflicts so that @ctoestreich can just "push the button"?

legart commented 10 years ago

Sorry @zyro23, had not seen there was a merge conflict. Fixed now.

jstorq commented 10 years ago

We are in the midst of upgrading from Grails 2.3.5 -> 2.4.1 and are wondering if/when this fix will be merged? Any information would be helpful.

ctoestreich commented 10 years ago

Will do it tonight.

Sent from Yahoo Mail on Android

jstorq commented 10 years ago

excellent. thank you!

ctoestreich commented 10 years ago

Released as 2.0

zyro23 commented 10 years ago

much appreciated. thanks!

jstorq commented 10 years ago

gracias!

jstorq commented 10 years ago

ever since getting the new version I'm getting "Groovy:Invalid duplicate class definition of class ApplicationResources: The sources .../plugins/cxf-2.0/grails-app/conf/ApplicationResources.groovy and .../grails-app/conf/ApplicationResources.groovy each contain a class with the name ApplicationResources. This is a compiler issue within Eclipse (GGTS). I upgraded to the 2.3 compiler as required for running Grails 2.4.1.

Any recommendations about this? Upgrading Grails from 2.3.5 to 2.4.1 is proving to be a fairly significant project. We are hoping to continue to use the resources plugin (1.2.8) for a while so the conversion of the static resource handling to asset-pipeline can be phased. Any thoughts would be helpful. Thanks!

ctoestreich commented 10 years ago

I will remove the artifacts that snuck in during upgrade and release 2.0.1 shortly.

On Wednesday, June 25, 2014 11:06 AM, jstorq notifications@github.com wrote:

ever since getting the new version I'm getting "Groovy:Invalid duplicate class definition of class ApplicationResources: The sources .../plugins/cxf-2.0/grails-app/conf/ApplicationResources.groovy and .../grails-app/conf/ApplicationResources.groovy each contain a class with the name ApplicationResources. This is a compiler issue within Eclipse (GGTS). I upgraded to the 2.3 compiler as required for running Grails 2.4.1. Any recommendations about this? Upgrading Grails from 2.3.5 to 2.4.1 is proving to be a fairly significant project. We are hoping to continue to use the resources plugin (1.2.8) for a while so the conversion of the static resource handling to asset-pipeline can be phased. Any thoughts would be helpful. Thanks! — Reply to this email directly or view it on GitHub.

jstorq commented 10 years ago

right on. thanks!