search

Grails-Plugin-Consortium / grails-filterpane

Filterpane plugin for grails.
Apache License 2.0
16 stars 44 forks source link

Clarified documentation #10

Closed stenix71 closed 11 years ago

stenix71 commented 11 years ago

Not really happy with the fact that the configuration files were added to this pull request but I cannot figure out how to remove them. I am quite a newbie to git. The only file that really matters is the filterlink.gdoc file. Is it really a good idea to keep the .project and .classpath files within version control? I think it would be easier to have a maven pom.xml file so that these files can be generated with the eclipse::eclipse command. There was a pom-file for a while but I think it got lost in one of the updates. Was it too hard to maintain it?

ctoestreich commented 11 years ago

I manually pulled in your changes. You might want to rebase (or delete and recreate your fork) to clean up the code and such.

I am not a maven fan and have never really used it. I am not opposed to putting back the pom xml, but the test scope plugins need to be defined. I think that is what was breaking it before. The plugins in the pom need to be not included in actual plugin during package and run. I am not quite sure how to tell maven to do that. If you want to take a stab at it feel free! Travis CI should let you know pretty quickly if the POM is valid and works.

tack så mycket!

stenix71 commented 11 years ago

I am not good enough at maven either to pull of such a task. That is probably the down-side of maven. Once you get a pom-file that works, maven is fantastic but to get there requires some headaches.

Ingen orsak! ;)